Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953514
Bug ID: 953514
Summary: Review Request: vmod-querystring - QueryString VMOD
for Varnish
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: unspecified
Assignee: nobody(a)fedoraproject.org
Reporter: dridi.boukelmoune(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Category: ---
Spec URL:
http://dl.bintray.com/v1/content/dridi/sources/vmod-querystring/0.2/#vmod...
SRPM URL:
http://dl.bintray.com/v1/content/dridi/sources/vmod-querystring/0.2/#vmod...
Fedora Account System Username: dridi
Description:
Hello,
I've written a module for Varnish, and I've tried to package it following
Fedora's
guidelines but it doesn't seem to fit. I would appreciate a review of my
current
work before submitting the real "0.2" release package (which will include your
review's modifications).
The module is a shared library, but there is no need for ldconfig in %pre and
%post scriptlets because it is loaded "manually" by varnish (and it lands on
%_libdir/varnish/vmods).
The module needs to be built along with Varnish, and Varnish won't load a
module
that was not built with the same exact version, which means that the module
requires more than just varnish (Requires: varnish = 3.0.x). So I had to make
some sort of conditional build, but it seems like --with[out] options in
rpmbuild
are only boolean switches.
The RPM is currently built with a %VARNISHVER macro equal to the varnish
version:
- rpmbuild -ba --define 'VARNISHVER 3.0.3' vmod-querystring.spec
- rpmbuild --rebuild --define 'VARNISHVER 3.0.3'
vmod-querystring-0.2-0.gitb3868eb.v3.0.3.fc18.src.rpm
- mock --define 'VARNISHVER 3.0.3'
vmod-querystring-0.2-0.gitb3868eb.v3.0.3.fc18.src.rpm
Unlike a --with[out] option, the %VARNISHVER macro isn't serialized in the
source
RPM so it is needed again when building the binary RPM.
To be able to build the same module against different versions of Varnish, I've
added a ".v3.0.x" string in the release tag, the version on the other hand is
the
same as the upstream project. One final word on the package name. The upstream
project is named libvmod-querystring, and I've stripped the lib prefix because
of some work on Varnish's side on the matter:
https://github.com/varnish/libvmod-example/blob/ab13e3ab6ff4093823f5c7775...
The vmod-example is a hello world module you can fork to make your own (it
contains a working build tree as a starting point).
For the vmod build, I use autogen.sh because I don't want to make a source
distribution with "make dist" since it needs to be %configured first with a
hard-coded path to the varnish build tree.
As for my own testing, I can build it on an x86 Fedora VM, except for varnish
3.0.3 (you'll find Fedora's patches for varnish 3.0.3 in the source RPM to make
it work). I can only build it for varnish 3.0.3 on my x64 Fedora Laptop. With
mock, the build fails on the rpmbuild command, but it works when I chroot to
mocks
build root and do it myself as mockbuild.
This is my first package for Fedora Extras, and it had to break the guidelines,
so please don't be too harsh. I hope I answered all your potential questions.
I also don't know whether I need a sponsor.
Best Regards,
Dridi
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=c0FQRTeJE2&a=cc_unsubscribe