https://bugzilla.redhat.com/show_bug.cgi?id=1324204
--- Comment #7 from Ondrej Faměra <ofamera(a)redhat.com> ---
- renamed to
fast-vm.spec
* %description line 29 is too long.
Line length shouldn't exceed 80 characters; cut it into two.
- done, put into
new line
* %{_libexecdir}/%{name}-helper.sh permissions look strange.
The file isn't world readable/executable. Wouldn't 755 make more sense?
-
the file is not intended to be executable by anyone other than root, but can
be readable by people - changed to 744.
* It appears 440 permissions are more common for sudoers files.
This isn't very important but consider changing yours.
- changed to 440
- marked
* You should own the %{_datadir}/bash-completion/completions
directory.
Just change line 45 to %{_datadir}/bash-completion/completions.
- changed
Thank you for suggestions. New .spec file and SRPM with changes from above can
be found below.
SRPM URL:
https://github.com/OndrejHome/fast-vm/releases/download/0.6.1/fast-vm-0.6...
Spec URL:
https://raw.githubusercontent.com/OndrejHome/fast-vm/develop/rpm/fast-vm....
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component