Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461757
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #14 from Parag AN(पराग) <panemade(a)gmail.com> 2008-09-24 02:15:31 EDT
---
Review:
+ package builds in mock (rawhide i386).
koji build =>
http://koji.fedoraproject.org/koji/taskinfo?taskID=841274
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
180e1264b77070b4814882671c4e57ba libdwarf-20080818.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package libdwarf-0.20080818-4.fc10 =>
Provides: libdwarf.so.0
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) rtld(GNU_HASH)
+ Package libdwarf-devel-0.20080818-4.fc10 =>
Requires: libdwarf.so.0
+ Package libdwarf-dwarfdump-0.20080818-4.fc10 =>
Provides: config(libdwarf-dwarfdump) = 0.20080818-4.fc10
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdwarf.so.0
libelf.so.1 libelf.so.1(ELFUTILS_1.0) rtld(GNU_HASH)
Suggestions:-
Good to see soname patch also applied in upstream.
APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.