https://bugzilla.redhat.com/show_bug.cgi?id=1766842
--- Comment #2 from Jeremy Newton <alexjnewt(a)fastmail.com> ---
(In reply to Ondřej Pohořelský from comment #1)
Hi, this is my first informal review and I would be glad to hear any
feedback on it.
Thanks for the review!
I would suggest getting in touch with upstream regarding license. You can't
add license file into a package from other source than upstream.
I see there is a disclaimer in gmc-display-config.c, but for valid Fedora
package you need a separate license file.
Yes you are correct, I should probably not include a license file.
I made a pull request:
https://github.com/jadahl/gnome-monitor-config/pull/1
In the meantime, I'll drop the license, but lack of license file shouldn't be a
blocker for acceptance into Fedora.
>%{!?_licensedir:%global license %%doc}
I guess this is used for compatibility with other older distributions. I
would suggest deleting this line and rely only on %License macro
This is for RHEL6, but since this likely won't work on older than RHEL7, I'll
drop it from the spec file.
Another thing is missing %check macro and tests.
There's nothing to test so I've skipped this section. This is a "should"
not a
"must", so it's not a blocker.
...
Rpmlint
-------
Checking: gnome-monitor-config-0-0.1.20190520.gitbc2f76c.fc32.x86_64.rpm
gnome-monitor-config-debuginfo-0-0.1.20190520.gitbc2f76c.fc32.x86_64.rpm
gnome-monitor-config-debugsource-0-0.1.20190520.gitbc2f76c.fc32.x86_64.rpm
gnome-monitor-config-0-0.1.20190520.gitbc2f76c.fc32.src.rpm
gnome-monitor-config.x86_64: W: spelling-error %description -l en_US xrandr
-> rand
gnome-monitor-config.x86_64: W: no-documentation
gnome-monitor-config.x86_64: W: no-manual-page-for-binary
gnome-monitor-config
gnome-monitor-config.src: W: spelling-error %description -l en_US xrandr ->
rand
4 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (debuginfo)
-------------------
Checking:
gnome-monitor-config-debuginfo-0-0.1.20190520.gitbc2f76c.fc32.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "cs_CZ.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "cs_CZ.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
gnome-monitor-config-debuginfo.x86_64: W: invalid-url URL:
https://github.com/jadahl/gnome-monitor-config <urlopen error [Errno -2]
Name or service not known>
gnome-monitor-config.x86_64: W: spelling-error %description -l en_US xrandr
-> rand
gnome-monitor-config.x86_64: W: invalid-url URL:
https://github.com/jadahl/gnome-monitor-config <urlopen error [Errno -2]
Name or service not known>
gnome-monitor-config.x86_64: W: no-documentation
gnome-monitor-config.x86_64: W: no-manual-page-for-binary
gnome-monitor-config
gnome-monitor-config-debugsource.x86_64: W: invalid-url URL:
https://github.com/jadahl/gnome-monitor-config <urlopen error [Errno -2]
Name or service not known>
3 packages and 0 specfiles checked; 0 errors, 6 warnings.
Looks like everything can be ignored here. Looks like you have an issue with
your perl locale though.
...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component