https://bugzilla.redhat.com/show_bug.cgi?id=1837107
--- Comment #17 from Andy Mender <andymenderunix(a)gmail.com> ---
Super big thanks for such a thorough review :)
(In reply to Robert-André Mauchin 🐧 from comment #16)
- Use install -p to keep timestamps
Done
Done.
- There is some BSD code:
BSD 3-clause "New" or "Revised" License
---------------------------------------
7kaa-2.15.3/include/misc_uuid.h
7kaa-2.15.3/src/misc_uuid.cpp
Add it to the license field and add a comment explaining the licenses
breakdown:
# Main program: GPLv2+
# misc_uuid: BSD
License: GPLv2+ and BSD
Done. I also re-ran licensecheck on the entire sources, since a new version
came out this weekend. There are some mentions of FSF All Permissive License
for m4 files. Should that also be included?
- Own this dir by removing the glob:
%{_datadir}/%{name}/
I always mess this up. Done.
- Split the data into a noarch data subpackage that you Requires
from the
main package:
[!]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Note: Arch-ed rpms have a total of 105809920 bytes in /usr/share
7kaa-2.15.3-5.fc33.x86_64.rpm:105809920
See:
https://fedoraproject.org/wiki/Packaging:
ReviewGuidelines#Package_Review_Guidelines
(...)
This is totally my fault. The original package would split out music and data
files. No idea why I merged the data package back into the main package. Fixed.
Issues:
=======
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/7kaa
See:
https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
Makes sense, since the package was orphaned :).
SPEC URL:
https://raw.githubusercontent.com/AndyMender/7kaa-rpm/f32/7kaa.spec
SRPM URL:
https://github.com/AndyMender/7kaa-rpm/blob/f32/7kaa-2.15.4-1.fc32.src.rp...
COPR build:
https://copr.fedorainfracloud.org/coprs/andymenderunix/7kaa/build/1518257/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component