https://bugzilla.redhat.com/show_bug.cgi?id=1004306
Christopher Meng <cickumqt(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review Request: opvdm - a |Review Request: opvdm - A
|tool for simulating organic |tool for simulating organic
|solar cells |solar cells
--- Comment #1 from Christopher Meng <cickumqt(a)gmail.com> ---
I really doubt if you've read the guidelines?
https://fedoraproject.org/wiki/Packaging:Guidelines
Let me quote all your spec:
------------------------------------------------------
=================
%define name opvdm
%define release 1
%define version 2.0
=================
Why do you waste 3 lines but not use
Name: opvdm
Version: 2.0
Release: 1%{?dist}
????????? Besides, you've missed dist tag.
------------------------------------------------------
=================
%define buildroot %{_tmppath}/%{name}-%{version}-root
=================
We don't need it. Now is 2013.
------------------------------------------------------
=================
BuildRequires: suitesparse-devel, zlib-devel, openssl-devel, gsl-devel,
blas-devel, libcurl-devel,
requires: gnuplot >= 4.6, python >= 2.7.5, suitesparse >= 4.0.2, blas >=
3.4.2
=================
Hi, can you move such things below basic information? It's abrupt.
And why did you write requires but not Requires?
------------------------------------------------------
=================
BuildRoot: %{buildroot}
Summary: Organic solar cell device model (OPVDM)
License: GNU V2.0 (Copyright Roderick MacKenzie 2013)
=================
Have you _read_ guidelines? ?? ???
GNU V2.0 (Copyright Roderick MacKenzie 2013) is invalid, see
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing
------------------------------------------------------
=================
Source: opvdm.tar
Prefix: /usr
Group: Development/Tools
AutoReqProv: yes
=================
Where does source come from?
Why did you define prefix but not using %{_prefix}
Why do you define AutoReqProv eq yes? In another way why do we have need to
write it?
------------------------------------------------------
=================
# I've not included a desktop file in this spec file because:
# The main program (opvdm_core) is command line line/text file driven.
# Although I have bundled a very simple GUI, it's a very early
# alpha version and not mature enough to want people to use it
# as the main way in which to interact with the program. The gui
# also requires you to prepare the directory structure with the
# command line before it is run.
=================
OK, but please make a better GUI when you release X+1 version or whatsoever.
------------------------------------------------------
=================
%description
An organic solar cell simulator (opvdm)
=================
Too short.
------------------------------------------------------
%prep
%setup -q
------------------------------------------------------
=================
%build
make
=================
Where is the smp flag?
https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
------------------------------------------------------
=================
%install
make DEST_DIR=%{buildroot} install
=================
------------------------------------------------------
=================
%files
%defattr(0444,root,root)
%attr(755, -, -) /bin/opvdm
%attr(755, -, -) /bin/opvdm_core
%attr(0444, -, -) /usr/opvdm/*.inp
%attr(0444, -, -) /usr/opvdm/image.jpg
%attr(0755, -, -) /bin/*.sh
%attr(0755, -, -) /usr/opvdm/plot
%attr(0755, -, -) /usr/opvdm/plot/*
=================
1. We don't need %defattr().
2. Have you used Fedora? /bin?
http://fedoraproject.org/wiki/Features/UsrMove
3. Can you ensure their permissions when install them but not using attr()?
You should drop all attr().
4. /usr/opvdm is not a good dir.
---> /usr/share/opvdm
5. /bin/*.sh for what?
6. 644 should be the best but not 444 as it's not standard.
7. You should use macro to list files but not hardcode them.
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
------------------------------------------------------
=================
#%doc %attr(0444,root,root) /usr/local/share/man/man1/wget.1
=================
Are you coming from Debian?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=PcGOFz1vFf&a=cc_unsubscribe