https://bugzilla.redhat.com/show_bug.cgi?id=2120130
Jakub Kadlčík <jkadlcik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|--- |If docs needed, set a value
CC| |jkadlcik(a)redhat.com
--- Comment #2 from Jakub Kadlčík <jkadlcik(a)redhat.com> ---
Hello Alessandro,
thank you for the package.
Overall it looks very good.
We have a tool called `fedora-review` which parses a Bugzilla ticket,
downloads the package, and performs some checks on it. Because of this,
the URL needs to be a direct link for downloading the SRPM file.
Exactly like this :-)
Unfortunately, the link returns 404 now. When you rebuild a package in
Copr, or build its newer version, the old package is automatically
removed after some time. If you have a pending review in Bugzilla, it
is a good idea to always update the SRPM and spec URLs when you
rebuild the package in Copr.
%global _description \
Cython extension module for gbinder
Can you please change the description into 2-3 full sentences? Looking
at the package as an outsider, I have no idea what gbinder is, and
what this extension module allows me to do.
python-gbinder.src: E: no-changelogname-tag
You don't have a %changelog section in your spec file, please take a
look here
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
[ ]: %check is present and all tests pass.
Looking at the source code, there is a tests directory present. If it
makes sense, can you please add a %check section to your spec file
and run the tests there?
https://docs.fedoraproject.org/en-US/package-maintainers/Packaging_Tutori...
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2120130