https://bugzilla.redhat.com/show_bug.cgi?id=1706659
Elliott Sales de Andrade <quantum.analyst(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |quantum.analyst(a)gmail.com
Assignee|nobody(a)fedoraproject.org |quantum.analyst(a)gmail.com
Flags| |fedora-review?
--- Comment #1 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com> ---
- The URL and Source look like they can use https://.
- rm -rf $RPM_BUILD_ROOT should be removed
- You do not need to install LICENSE.txt manually; just list it as a relative
path and it will be installed for you.
- Summary should not end in a period.
- If you've built the tests, why not run them in %check?
- %changelog is missing version-release
- This fails to build for me due to missing armadillo; why is it not in
BuildRequires also? (I don't think a new enough armadillo is packaged in
Fedora, though.)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component