https://bugzilla.redhat.com/show_bug.cgi?id=1009750
Christopher Meng <cickumqt(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cickumqt(a)gmail.com
--- Comment #1 from Christopher Meng <cickumqt(a)gmail.com> ---
1. BuildRequires: python-setuptools-devel
-->
BuildRequires: python-setuptools
AND
BuildRequires: python-devel
-->
BuildRequires: python2-devel
2. rm -rf $RPM_BUILD_ROOT is not needed in modern system.
3. Good to see using %{__python2}, but you forgot it in %install
4. %{python_sitearch} --> %{python2_sitearch}
5. You forgot to use nose or tox to test as RPM %check.
https://github.com/racker/falcon/blob/master/README.md#test
6. No python3 support? Why?
7. You can add features listed on pypi as RPM %description:
Features
- Intuitive routing via URI templates and resource classes
- Easy access to headers and bodies through request and response classes
- Idiomatic HTTP error responses via a handy exception base class
- DRY request processing using global, resource, and method hooks
- Snappy unit testing through WSGI helpers and mocks
- 20% speed boost when Cython is available
- Python 2.6, Python 2.7, PyPy and Python 3.3 support
- Speed, speed, and more speed!
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=n36I0JyAnc&a=cc_unsubscribe