Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=565858
Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtasaka(a)ioa.s.u-tokyo.ac.jp
--- Comment #1 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> 2010-02-16 10:56:24
EST ---
Some quick notes
- build fails, at least BR: ruby-devel is needed
http://koji.fedoraproject.org/koji/taskinfo?taskID=1990997
- C extension modules should be installed under %ruby_sitearch,
not under %geminstdir
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_packages_with_binary_c...
- To create debuginfo rpms correctly, you once have to install gem file
under %_builddir (i.e. you cannot install this gem file under
%buildroot directory, otherwise creating debuginfo rpm fails:
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_lib...
- As this gem contains spec/ directory, please add %check
section and execute some test program (like $ rake spec ) there.
- Please use defined %geminstdir macro in %files
- "CHANGELOG" "COPYING" "README" (and usually also
"Rakefile") should
correctly marked as %doc.
Also benchmark/ example/ spec/ tasks/ directories can perhaps be
marked as %doc.
- ext/ directory are to compile C extention module (thin_parser.so)
and need not be packaged into binary rpm.
- It seems that license tag should be "MIT and BSD and (Ruby or GPLv2)",
however I will recheck this later.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.