Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=487312
--- Comment #2 from Phil Knirsch <pknirsch(a)redhat.com> 2009-02-26 07:48:16 EDT ---
(In reply to comment #1)
Hm, I wonder why there is a devel-dependency for kernel-debuginfo. I see that
the scripts are systemtap scripts. Therefore this should be OK.
Yea, i was wondering about that as well. Seems that rpmlint assumes that if you
install a debuginfo package you want to to development instead of debugging. ;)
Packaging guidelines:
Can you please fix the URL for the git tree to be consistent and maybe add a
description how to get the proper version from git? Please also fix the url in
the wiki page. (See:
https://fedoraproject.org/wiki/Packaging/SourceURL)
Added the following over the Source tag:
# The source for this package was pulled from upstream git. Use the
# following commands to get the corresponding tarball:
# git clone
git://fedorapeople.org/~pknirsch/tuned.git/
# cd tuned
# git checkout v%{version}
# make archive
(similar to the upstream CVS description in the SourceURL docu)
Can you please use "%(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)" for Buildroot? (See:
BuildRoot tag at
https://fedoraproject.org/wiki/Packaging/Guidelines)
Fixed.
Please fix whitespaces in the GPL headers (example: tuned).
Fixed.
Why is tuningplugins/__init__.py empty?
Intentionally left empty. ;) But in all seriousness, Python packages require
you to install at least an empty __init__.py to work, see
http://docs.python.org/tutorial/modules.html#packages. I've added a comment
line to both __init__.py files now.
Why is there a reference to configure in INSTALL. There is no
configure script
at all.
Uhm, yea, thats was just the standard GNU INSTALL file. I've stripped it down
"a little" now so it only contains what really can be done.
New packages are now up:
Spec URL:
http://pknirsch.fedorapeople.org/src/tuned.spec
SRPM URL:
http://pknirsch.fedorapeople.org/src/tuned-0.1.1-1.fc10.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.