https://bugzilla.redhat.com/show_bug.cgi?id=1374947
--- Comment #4 from Michal Ruprich <mruprich(a)redhat.com> ---
Hi Athmane,
there are more issues than just the one you mentioned. They are marked with !
in the review. But I understand that one can easily miss that so I will repeat
them here:
[!]: Package is named according to the Package Naming Guidelines.
##Because this beeing a svn snapshot version, it would be good to name
it according to
https://fedoraproject.org/wiki/Packaging:Versioning#NonNumericRelease
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
https://sourceforge.net/code-
snapshots/svn/v/vp/vpcs/code/vpcs-code-126-trunk.zip
See:
http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
##Double check the link, I wasn't able to connect to it
[!]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
##Again the same as the problem with URL
[!]: %check is present and all tests pass.
They are just minor issues. Please take a look at them.
Thank you
Michal
##Add %check section
[!]: SourceX is a working URL.
##Mentioned above
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component