Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: iwlwifi-firmware - Microcode for Intel® PRO/Wireless 3945 A/B/G
network adaptors
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230096
------- Additional Comments From lxtnow(a)gmail.com 2007-02-27 07:59 EST -------
Hi Matthias,
indeed, there's some things can be ignored in review and from rpmlint ouput error.
That's invalid for firmware. /lib is correct.
for %{_lib}, it works for me and no build error.
Typo: # This is so that the noarch packages only appears for these
archs
And what about pcc arch ?
This driver is invalid on PPC.
So, this :
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179260
should be read.
For instance "you must use a %{?dist}
tag" is incorrect, and in this case, it's _deliberate_ to not use one, since it
allows hardlinking the package across multiple releases.
I understand that. also the fact it's a noarch package.
Now i wonder if it's accepted in CVS build procedure.
Your only valid comment is the one about the %changelog, but please
realize that
it's pretty much useless to have multiple entries for the same day, especially
if they're so minor. The wrong thing would have been not to increment the release.
I a little bit agree with you about that (i don't make multiple entries for the
same day when i build my own packages) but, it's important for review to avoid
confusions and to follow the work (changes, modification, ...) of the owner of
the package.
however, I maintains that the Group tag isn't good.
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.