Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=893566
--- Comment #5 from Martin Sourada <martin.sourada(a)gmail.com> ---
(In reply to comment #4)
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at
the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
Fixed.
[!]: License field in the package spec file matches the actual
license.
Note: JMdict and kanjidic2 is licensed under CC-BY-SA. Upstream
statement:
http://www.edrdg.org/edrdg/licence.html
So the main package License should be 'GPLv3+ and CC-BY-SA', and the
License of dic packages should be 'CC-BY-SA'.
Fixed. (Also the db
files moved to noarch subpackage as mentioned bellow, by
the docs and some of the icons are CC-BY-SA as well, so leaving that there as
well).
[!]: Large data in /usr/share should live in a noarch subpackage if
package
is
arched.
Note: Arch-ed rpms have a total of 66068480 bytes in /usr/share 66068480
tagainijisho-0.9.4-2.fc19.x86_64.rpm
%{_datadir}/%{name} directory can be packaged into a separate noarch
subpackage like %{name}-common. And %{name} and %{name}-common can require
each other.
I moved the main jmdict and kanjidic2 database file to %{name}-common
and made
the language specific databases' subpackages depend on that instead.
tagainijisho-dic-fr.noarch: W: spelling-error Summary(en_US) Tagaini
-> Again
tagainijisho-dic-fr.noarch: W: no-documentation
Tagaini is program name.
tagainijisho.x86_64: W: spelling-error %description -l en_US Tagaini
-> Again
tagainijisho.x86_64: W: spelling-error %description -l en_US kanji -> Kantian
kanji the name of the Japanese characters
tagainijisho.x86_64: W: spelling-error %description -l en_US lookup
->
Missing in the dictionary? See e.g.
http://www.merriam-webster.com/dictionary/lookup
tagainijisho.x86_64: E: zero-length
/usr/share/tagainijisho/detailed_default.html
tagainijisho.x86_64: E: zero-length
/usr/share/tagainijisho/detailed_jmdict.css
I'm not 100% sure if it would work
fully correctly without them.
tagainijisho.x86_64: W: no-manual-page-for-binary tagainijisho
GUI app, does not have any.
===== Other comments =====
* Remember to add the dic packages to proper language comps, so that
yum-langpacks can work as usaul.
Thanks for the reminder.
New SPEC:
http://mso.fedorapeople.org/packages/SPECS/tagainijisho.spec
New SRPM:
http://mso.fedorapeople.org/packages/SRPMS/tagainijisho-0.9.4-3.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ZgBNXLqGV3&a=cc_unsubscribe