https://bugzilla.redhat.com/show_bug.cgi?id=2016693
Ben Beasley <code(a)musicinmybrain.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(code@musicinmybra |needinfo?(vanessaigwe1@gmai
|in.net) |l.com)
--- Comment #12 from Ben Beasley <code(a)musicinmybrain.net> ---
There’s something I missed in the initial review. This library loads
“libopenjp2” at runtime using ctypes.CDLL, so it needs it as a dependency. It’s
perfectly happy to open the versioned shared object (e.g. libopenjp2.so.7), so
you can depend on openjpeg2 rather than openjpeg2-devel.
I guess the tests are working because one of your BuildRequires already has
openjpeg2 as a transitive dependency. However, you should make the build-time
dependency explicit, and also add the runtime dependency:
BuildRequires: openjpeg2
# libopenjp2 is loaded via ctypes
Requires: openjpeg2
-----
I don’t have time to talk through the PDF documentation right now, but I’m
happy to do so a little later. It’s by no means needed for approval! However,
if you’re interested in trying it by example, you can take a look at
https://src.fedoraproject.org/rpms/python-socketio/blob/rawhide/f/python-....
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2016693