https://bugzilla.redhat.com/show_bug.cgi?id=2001684
--- Comment #6 from Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> ---
(In reply to Miro Hrončok from comment #4)
My personal opinion: Do not define %{pypi_name}, %{pretty_name},
%{srcname},
etc. at all: it just makes the specfile hard to read. Use explicit value
everywhere. E.g. use %{pypi_source keyrings.alt}.
The Python guidelines don't really explicitly mention this, but they do the
same thing in examples. The %{pypi_source} documentation even says the
automatic name is deprecated:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pypi_so...
Relevant discussion:
https://lists.fedoraproject.org/archives/list/python-devel@lists.
fedoraproject.org/message/RDNMKJHCLOL57W37EY2GQQ2Y5MAJ43MK/
--------
Thanks for that. That makes sense. I'll stop using these name related macros
from now onwards and use the names directly instead.
About %pyproject_save_files: it always includes the one .dist-info
directory
+ it takes a list of module names globs to include. If there are multiple
.dist-info directories found, it will fail.
Oh, OK. good to know.
(In reply to Miro Hrončok from comment #5)
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Package APPROVED.
Awesome, thanks for the review!
Nitpicks:
LICENSE is packaged twice:
$ rpm -ql --licensefiles -p python3-keyrings-alt-4.1.0-1.fc36.noarch.rpm
/usr/lib/python3.10/site-packages/keyrings.alt-4.1.0.dist-info/LICENSE
/usr/share/licenses/python3-keyrings-alt/LICENSE
Removed the duplicate entry. I forget that distinfo includes it already.
What does this comment relate to?
# pyfilesystem is not yet packaged
# gdata, keyczar are deprecated
These are additional bits needed for particular tests---gdata and keyczar are
only available on Python 2, so their tests are skipped. I thought pyfilesystem
wasn't in Fedora, but I found it included as python-fs. The pyfs tests are
still skipped in the build though---but they are also skipped in upstream's CI,
so not sure what needs to be done to get them to run:
https://github.com/jaraco/keyrings.alt/runs/3082737541?check_suite_focus=...
I've improved the comment in the spec.
Be careful if you ever package anything else that owns
/usr/lib/python3.10/site-packages/keyrings/__init__.py
+1, I've made a note of this in the spec too.
Thanks again, requesting SCM now.
Updated spec/srpm:
Spec URL:
https://ankursinha.fedorapeople.org/python-keyrings-alt/python-keyrings-a...
SRPM URL:
https://ankursinha.fedorapeople.org/python-keyrings-alt/python-keyrings-a...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component