Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891212
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(tchollingsworth@g
| |mail.com)
--- Comment #2 from Miro Hrončok <mhroncok(a)redhat.com> ---
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces.
$ rpmlint ../RPMS/noarch/nodejs-npmconf-0.0.16-2.fc18.noarch.rpm
../SRPMS/nodejs-npmconf-0.0.16-2.fc18.src.rpm
nodejs-npmconf.noarch: W: spelling-error Summary(en_US) npm -> pm, rpm, ppm
nodejs-npmconf.noarch: W: summary-not-capitalized C npm configuration module
nodejs-npmconf.noarch: W: spelling-error %description -l en_US config -> con
fig, con-fig, configure
nodejs-npmconf.noarch: W: spelling-error %description -l en_US npm -> pm, rpm,
ppm
nodejs-npmconf.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-npmconf.noarch: W: spelling-error %description -l en_US reccomends ->
recommends, recommend, commends
nodejs-npmconf.noarch: W: spelling-error %description -l en_US rc -> RC, r, c
nodejs-npmconf.noarch: W: only-non-binary-in-usr-lib
nodejs-npmconf.noarch: W: dangling-symlink
/usr/lib/node_modules/npmconf/node_modules/inherits
/usr/lib/node_modules/inherits
nodejs-npmconf.noarch: W: dangling-symlink
/usr/lib/node_modules/npmconf/node_modules/once /usr/lib/node_modules/once
nodejs-npmconf.noarch: W: dangling-symlink
/usr/lib/node_modules/npmconf/node_modules/config-chain
/usr/lib/node_modules/config-chain
nodejs-npmconf.noarch: W: dangling-symlink
/usr/lib/node_modules/npmconf/node_modules/mkdirp /usr/lib/node_modules/mkdirp
nodejs-npmconf.noarch: W: dangling-symlink
/usr/lib/node_modules/npmconf/node_modules/osenv /usr/lib/node_modules/osenv
nodejs-npmconf.noarch: W: dangling-symlink
/usr/lib/node_modules/npmconf/node_modules/nopt /usr/lib/node_modules/nopt
nodejs-npmconf.src: W: spelling-error Summary(en_US) npm -> pm, rpm, ppm
nodejs-npmconf.src: W: summary-not-capitalized C npm configuration module
nodejs-npmconf.src: W: spelling-error %description -l en_US config -> con fig,
con-fig, configure
nodejs-npmconf.src: W: spelling-error %description -l en_US npm -> pm, rpm, ppm
nodejs-npmconf.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-npmconf.src: W: spelling-error %description -l en_US reccomends ->
recommends, recommend, commends
nodejs-npmconf.src: W: spelling-error %description -l en_US rc -> RC, r, c
2 packages and 0 specfiles checked; 0 errors, 21 warnings.
Symlinks OK, package requires npm(config-chain), npm(inherits), npm(mkdirp),
npm(nopt), npm(once) and npm(osenv)
MUST: The spec file must be written in American English.
FIX: spelling-error %description -l en_US reccomends -> recommends
All other false positives.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE file, BSD. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/npmconf-0.0.16.tgz
3fd5a4274d05babcb5fea497becfe0468f86ef5c6171a02e2c4e208e9542bf70
../SOURCES/npmconf-0.0.16.tgz
$ spectool -g nodejs-npmconf.spec
Getting
http://registry.npmjs.org/npmconf/-/npmconf-0.0.16.tgz to
./npmconf-0.0.16.tgz
$ sha256sum npmconf-0.0.16.tgz
3fd5a4274d05babcb5fea497becfe0468f86ef5c6171a02e2c4e208e9542bf70
npmconf-0.0.16.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense. OK, build
in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-npmconf-0.0.16-2.fc18.noarch.rpm
drwxr-xr-x 2 root root 0 led 17 07:13
/usr/lib/node_modules/npmconf
-rw-r--r-- 1 root root 13307 zář 13 05:11
/usr/lib/node_modules/npmconf/config-defs.js
drwxr-xr-x 2 root root 0 led 17 07:13
/usr/lib/node_modules/npmconf/node_modules
lrwxrwxrwx 1 root root 34 led 17 07:13
/usr/lib/node_modules/npmconf/node_modules/config-chain ->
/usr/lib/node_modules/config-chain
lrwxrwxrwx 1 root root 30 led 17 07:13
/usr/lib/node_modules/npmconf/node_modules/inherits ->
/usr/lib/node_modules/inherits
lrwxrwxrwx 1 root root 28 led 17 07:13
/usr/lib/node_modules/npmconf/node_modules/mkdirp ->
/usr/lib/node_modules/mkdirp
lrwxrwxrwx 1 root root 26 led 17 07:13
/usr/lib/node_modules/npmconf/node_modules/nopt -> /usr/lib/node_modules/nopt
lrwxrwxrwx 1 root root 26 led 17 07:13
/usr/lib/node_modules/npmconf/node_modules/once -> /usr/lib/node_modules/once
lrwxrwxrwx 1 root root 27 led 17 07:13
/usr/lib/node_modules/npmconf/node_modules/osenv -> /usr/lib/node_modules/osenv
-rw-r--r-- 1 root root 8748 srp 30 22:12
/usr/lib/node_modules/npmconf/npmconf.js
-rw-r--r-- 1 root root 664 zář 13 05:11
/usr/lib/node_modules/npmconf/package.json
drwxr-xr-x 2 root root 0 led 17 07:13
/usr/share/doc/nodejs-npmconf-0.0.16
-rw-r--r-- 1 root root 1310 zář 12 02:43
/usr/share/doc/nodejs-npmconf-0.0.16/LICENSE
-rw-r--r-- 1 root root 1050 srp 15 02:26
/usr/share/doc/nodejs-npmconf-0.0.16/README.md
OK
MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK
TODO: Run tests, when possible.
Package NEEDSWORK, just correct the typo.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=kpmtceFDp9&a=cc_unsubscribe