Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=876865
Kevin Fenzi <kevin(a)scrye.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends On|177841 (FE-NEEDSPONSOR) |
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #8 from Kevin Fenzi <kevin(a)scrye.com> ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream sha256sum:
bda33075ed54c6702412e035f0f7eee417d4f6084ba4137ecb75912f65d4d114
brewtarget_1.2.5.orig.tar.gz
bda33075ed54c6702412e035f0f7eee417d4f6084ba4137ecb75912f65d4d114
brewtarget_1.2.5.orig.tar.gz.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package is a GUI app and has a .desktop file
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
Issues:
1. Might ask upstream to include a copy of LGPL? (not a blocker)
2. rpmlint says:
brewtarget.i686: W: spurious-executable-perm
/usr/share/man/man1/brewtarget.1.gz
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Might fix the perms on the man page when installing it. Should be 644.
Thats a pretty minor issue, so if you could fix that before importing thats
fine
with me and this package is APPROVED.
I will go ahead and sponsor you, please let me know if you run into any
questions...
You can continue the process from:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Ad...
Welcome to packaging fun! :)
--
You are receiving this mail because:
You are on the CC list for the bug.