https://bugzilla.redhat.com/show_bug.cgi?id=1693014
Georg Sauthoff <fedora(a)georg.so> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review?
--- Comment #3 from Georg Sauthoff <fedora(a)georg.so> ---
Ok, my first round of review feedback:
The python3-pip build dependency looks superfluous.
The python3-flit build dependency isn't strictly necessary.
I mean the archive from PyPi includes a setup.py and thus we could use that
instead.
For example like this:
--- python-pyrpm.spec.orig 2019-03-28 14:47:24.842994924 +0100
+++ python-pyrpm.spec 2019-03-28 16:04:34.998208523 +0100
@@ -10,12 +10,10 @@
License: MIT
URL:
https://github.com/bkircher/python-rpm-spec
-Source0: %url/archive/%{version}/%{reponame}-%{version}.tar.gz
+Source0: %pypi_source %{reponame}
BuildArch: noarch
BuildRequires: python3-devel
-BuildRequires: python3-flit
-BuildRequires: python3-pip
%if %{with tests}
BuildRequires: python3-pytest
%endif
@@ -41,11 +39,11 @@
%prep
%autosetup -n %{reponame}-%{version}
+%build
+%py3_build
%install
-export PYTHONUSERBASE=%{buildroot}%{_prefix}
-export FLIT_NO_NETWORK=1
-flit install --deps none
+%py3_install
%if %{with tests}
@@ -58,7 +56,7 @@
%license LICENSE
%doc AUTHORS CHANGELOG.md README.md examples/
%{python3_sitelib}/%{pypi_name}
-%{python3_sitelib}/python_rpm_spec-%{version}.dist-info
+%{python3_sitelib}/python_rpm_spec-*-py*.egg-info
%changelog
The description text is duplicated between the source package and sub-package.
It makes sense to de-duplicate it with a macro, e.g.:
%global common_description %{expand:
... the desc ...
}
...
%description
%{common_description}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component