https://bugzilla.redhat.com/show_bug.cgi?id=1080411
--- Comment #4 from Karel Volný <kvolny(a)redhat.com> ---
(In reply to Rex Dieter from comment #2)
Offhand looks like a good start, some initial suggestions (SHOULD are
just
recommendations and/or a matter of taste, MUST are required):
thanks
1. SHOULD add
Requires: hicolor-icon-theme
instead of:
%dir %{_datadir}/icons/hicolor
%dir %{_datadir}/icons/hicolor/*
I prefer not to add dependencies that are not really needed ... multiple
ownership of a directory seems to me less evil
shame on me, I've completely forgotten about this gnomish stuff
(hm, now I wonder if I've overlooked it in the review, or such checkpoint is
missing? - RFE material? - but I'm not in the mood to investigate now with all
those errata in my queue :-/)
3. SHOULD include .spec comments clearly identifying items that are
workarounds for the bugs referenced in comment #1
added
@Christopher:
I'm going to attach new spec version here, is that okay for you, or do I have
to reupload it on the web together with new srpm?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component