Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=618985
--- Comment #7 from Jan Kaluža <jkaluza(a)redhat.com> 2010-08-04 08:12:46 EDT ---
Spec URL:
http://jkaluza.fedorapeople.org/swift.spec
SRPM URL:
http://jkaluza.fedorapeople.org/swift-1.0-0.3.beta5.fc13.src.rpm
kojid build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2379059
[ERR] License must be Fedora approved; Licensing Guidelines.
[ERR] The License field in the package spec file must match the actual license.
[ERR] license file must packaged in %doc.
The spec says "License: GPLv3+", but the sources appear to be under GPL v3
only
(no later version).
The tarball contains the text of the license in the "COPYING" file - it should
be included as %doc in the binary package.
Just now it's "License: GPLv3". COPYING file is installed
too.
[ERR] consistent macro usage
The uses both %{buildroot} and ${RPM_BUILD_ROOT}. Choose one and stick to it.
Only %{buildroot} is used now.
I don't see %{optflags} being applied. Koji build log indicates
they are not
passed (for instance, there's no mention of _FORTIFY_SOURCE).
Fixed.
BTW, a PNG is usually preferred nowadays, but XPM is acceptable.
For 32x32 px size, upstream provides only .xpm icon in. If other sizes are
allowed (I couldn't find it anywhere), I can install .png.
[ERR] timestamps
swift.xpm is installed without using "-p".
Fixed.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.