https://bugzilla.redhat.com/show_bug.cgi?id=2064302
--- Comment #2 from Hirotaka Wakabayashi <hiwkby(a)yahoo.com> ---
Hi Remi, please see my review.
Issues:
* One rpmlint error. please see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_rpmlint
```
# rpmlint php-sebastian-type3-3.0.0-1.fc37.noarch.rpm
============================================================================================
rpmlint session starts
============================================================================================
rpmlint: 2.2.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
php-sebastian-type3.noarch: E: summary-too-long Collection of value objects
that represent the types of the PHP type system, version 3
php-sebastian-type3.noarch: W: description-shorter-than-summary
============================================================= 1 packages and 0
specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.0 s
=============================================================
# rpmlint php-sebastian-type3-3.0.0-1.remi.src.rpm
============================================================================================
rpmlint session starts
============================================================================================
rpmlint: 2.2.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
php-sebastian-type3.src: E: unknown-key 1fef0014
php-sebastian-type3.src: E: summary-too-long Collection of value objects that
represent the types of the PHP type system, version 3
php-sebastian-type3.src: W: strange-permission makesrc.sh 775
php-sebastian-type3.spec: W: invalid-url Source0:
php-sebastian-type3-3.0.0-b233b84.tgz
php-sebastian-type3.src: W: description-shorter-than-summary
============================================================= 1 packages and 0
specfiles checked; 2 errors, 3 warnings, 2 badness; has taken 0.1 s
=============================================================
```
* It's may not an issue but rpmbuild should stop building the package when
`which` command fails because the test suite will not be executed.
```
%if %{with tests}
...(snip)...
: Run upstream test suite
ret=0
for cmd in php php74 php80 php81; do
if which $cmd; then
...(snip)...
%else
: bootstrap build with test suite disabled
%endif
```
Memos to build the package manually:
```
% docker run -ti --privileged fedora-container-base-rawhide-20220626.n.0.x86_64
/bin/bash
# curl -o php-sebastian-type3.spec
https://git.remirepo.net/cgit/rpms/php/sebastian/php-sebastian-type3.git/...
# curl -o php-sebastian-type3-3.0.0-1.remi.src.rpm
https://rpms.remirepo.net/SRPMS/php-sebastian-type3-3.0.0-1.remi.src.rpm
# dnf update -y
# dnf install -y mock
# mock -r /etc/mock/fedora-rawhide-x86_64.cfg --clean
# mock -r /etc/mock/fedora-rawhide-x86_64.cfg --no-clean
php-sebastian-type3-3.0.0-1.remi.src.rpm
# mock -r /etc/mock/fedora-rawhide-x86_64.cfg --no-clean --copyout
/builddir/build/RPMS/*.rpm .
# dnf install -y rpmlint
# rpmlint *.rpm
```
Thanks in advance,
Hirotaka
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2064302