https://bugzilla.redhat.com/show_bug.cgi?id=2154518
Diego Herrera <dherrera(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nobody(a)fedoraproject.org |dherrera(a)redhat.com
CC| |dherrera(a)redhat.com
Flags| |fedora-review?
--- Comment #2 from Diego Herrera <dherrera(a)redhat.com> ---
I'm currently starting to review this package. Here are some things that caught
my eye on my first glance:
* Even if python3-onnx implicitly depends on onnx-libs since it needs the
libonnx.so lib, I think you should still make the requirement explicit because
the license information is on the onnx-libs package.
* You should use the SPDX expression in the License field [0] (in this case,
Apache-2.0 instead of ASL 2.0 [1])
[0]
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidel...
[1]
https://docs.fedoraproject.org/en-US/legal/allowed-licenses/
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2154518