https://bugzilla.redhat.com/show_bug.cgi?id=1372836
Iryna Shcherbina <ishcherb(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ishcherb(a)redhat.com
--- Comment #1 from Iryna Shcherbina <ishcherb(a)redhat.com> ---
Hi Haïkel,
This is an informal review, as I cannot approve the package until I am
sponsored, but I would like to point your attention to a couple of issues I
have noticed:
* 2.1.2 is not the latest version. hug 2.2.0 is already available on pypi
(
https://pypi.python.org/pypi/hug/). And you can now include %doc and %license
(as your PR was merged and went into the release).
* You can use
files.pythonhosted.org for the Source0 url to conform to
SourceUrl guidelines for pypi packages
(
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL...).
* You can use `Summary: %{summary}` macro in your python3- subpackage, which
will contain the content of the first Summary tag.
* What is the purpose of python3-mock and python3-pytest in BuildRequires?
I hope my review was helpful.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component