Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: smstools - Tools for send and receive short messages through GSM
modems or mobile phones
https://bugzilla.redhat.com/show_bug.cgi?id=374771
------- Additional Comments From lkundrak(a)redhat.com 2007-11-10 11:05 EST -------
Marek: The package looks superb. Just a few minor notes before I can approve it:
Summary is not correct american english.
I believe the License is GPLv2+, not GPLv2
RPMlint output:
Lot of
smstools.i386: W: wrong-file-end-of-line-encoding
/usr/share/doc/smstools-2.2.18/index.html
and
smstools.i386: W: wrong-file-end-of-line-encoding
/usr/share/doc/smstools-2.2.18/license.html
you probably need some recode/iconv/dos2unix magic
smstools.src:22: W: setup-not-quiet
just add -q to %setup
smstools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 1)
safe to ignore
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.