https://bugzilla.redhat.com/show_bug.cgi?id=1211831
Antonio Trande <anto.trande(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anto.trande(a)gmail.com
--- Comment #7 from Antonio Trande <anto.trande(a)gmail.com> ---
(In reply to Gerald Cox from comment #6)
It's a stylistic choice, I think it makes it easier to maintain
the spec. I
didn't see where they were predefined:
http://rpm.org/api/4.4.2.2/config_macros.html
Name: copyq
Summary: Advanced clipboard manager
Version: 2.4.6
Release: 1%{?dist}
License: GPLv3+
Url:
http://sourceforge.net/projects/copyq/
Source0:
http://sourceforge.net/projects/copyq/files/%{name}-%{version}.tar.gz
BuildRequires: cmake, libXtst-devel, qt4-devel, qtwebkit-devel
---
%global name %global version %global release %global build_req
are redundant.
See
http://fedoraproject.org/wiki/How_to_create_an_RPM_package
Can you give me a URL if it is an issue?
$ cat /usr/lib/rpm/macros
---
Then
1) %{__make} %{?jobs:-j%jobs} --> make %{?_smp_mflags}
You don't need to indicate full path to the executable
2) %{_datadir}/applications/%{name}.desktop
You must validate every desktop file.
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_u...
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
3) %{_datadir}/icons/hicolor/*/apps/%{name}*.svg
"If an application installs icons into one of the subdirectories in
%{_datadir}/icons/ (such as hicolor in the following examples), icon caches
must be updated so that the installed icons show up in menus right after
package installation."
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
4) %{_datadir}/copyq/translations/*.qm
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
5)
%clean
rm -rf $RPM_BUILD_ROOT
%defattr(-,root,root)
Unless you wish to package copyq in EPEL5, commands above are redundant.
http://fedoraproject.org/wiki/EPEL:Packaging#Cleaning_BuildRoot_in_.25clean
6) Use %license macro to mark the LICENSE file.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component