Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=736994
Vít Ondruch <vondruch(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review+
--- Comment #5 from Vít Ondruch <vondruch(a)redhat.com> 2011-09-23 04:46:28 EDT ---
* Incoherent version in changelog
- From rpmlint outpu: rubygem-bson_ext.i686: W:
incoherent-version-in-changelog
1.3.1-3 ['1.4.0-1.fc17', '1.4.0-1']
- You forgot to update the changelog version accordingly.
* The test cleanup should be done in the same section as the test preparation
- Since the test are unpacked required just in %check section, I would
suggest
to clean them in the same section
- Another alternative would be to unpack the using %setup macro, but I am not
aware of any other package which is prepared this way. It might be worth of
investigation
Please fix this nits before import. Otherwise the package looks good =>
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.