https://bugzilla.redhat.com/show_bug.cgi?id=2018825
Ben Beasley <code(a)musicinmybrain.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
|needinfo?(code@musicinmybra |
|in.net) |
--- Comment #10 from Ben Beasley <code(a)musicinmybrain.net> ---
I have inspected the spec file diff (below) and confirmed the issue from the
previous review is corrected. Thanks! The package is therefore approved.
--- 20211105/2018825-python-cro/srpm-unpacked/python-cro.spec 2021-11-04
14:23:38.000000000 -0400
+++ 20211106/2018825-python-cro/srpm-unpacked/python-cro.spec 2021-11-06
17:20:13.000000000 -0400
@@ -25,7 +25,15 @@
# to requirements.txt.
Patch0: 58-pypi.patch
Patch1: %{url}/pull/59.patch
-
+
+# Import Bunch from sklearn.utils
+#
https://github.com/VictorPelaez/coral-reef-optimization-algorithm/pull/63
+#
+# Fixes:
+# Import of Bunch needs to be fixed for recent scikit-learn versions
+#
https://github.com/VictorPelaez/coral-reef-optimization-algorithm/issues/62
+Patch2: %{url}/pull/63.patch
+
BuildArch: noarch
BuildRequires: python3-devel
@@ -70,6 +78,17 @@
#
https://github.com/VictorPelaez/coral-reef-optimization-algorithm/pull/59
# Patch1: %{url}/pull/59.patch
+%check
+# Upstream provides no tests
+%pyproject_check_import
+# Also use the examples as “smoke tests”
+pushd examples
+for example in example_*.py
+do
+ PYTHONPATH='%{buildroot}%{python3_sitelib}' %{python3} "${example}"
+done
+popd
+
%files -n python3-%{pypi_name} -f %{pyproject_files}
%license LICENSE.txt
%doc README.txt examples
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2018825