https://bugzilla.redhat.com/show_bug.cgi?id=1982801
--- Comment #2 from Major Hayden 🤠 <mhayden(a)redhat.com> ---
(In reply to Ben Beasley from comment #1)
===== Issues =====
- Please add CODE_OF_CONDUCT.md, CONTRIBUTING.rst, SECURITY.md, and
UPGRADING.md as %doc, either in the base package or in the -doc subpackage.
Thanks for catching that. I'll add those to the base package on import.
===== Notes (no change required) =====
- I was going to ask you to add
%pyproject_extras_subpkg -n python3-%{srcname} fixup
to create the metapackage
(
https://fedoraproject.org/wiki/Changes/PythonExtras#Extras_metapackages)
for
the “fixup” extra, but then I noticed that this only supports the
“fixup_credentials_v1_keywords.py” script, which you are not shipping—so I
think omitting this extra makes sense.
I looked through the script and it doesn't seem like it has much use with the
current code. I also wanted to avoid clogging up %{_bindir} with something that
didn't seem to be required.
Thanks for reviewing! 🤗
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component