https://bugzilla.redhat.com/show_bug.cgi?id=1801533
--- Comment #2 from Kairui Song <kasong(a)redhat.com> ---
(In reply to Artur Iwicki from comment #1)
Thank you very much for the review.
>Spec URL:
https://gist.github.com/ryncsn/ed41a2d265ce6c897b1d87212a7a1754
This points to an HTML web-view of the file; please use "raw file" links.
OK, will fix that.
>Group: Applications/System
The Group: tag is not used in Fedora.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sect...
>%package dracut-memstrack
This will create a "memstack-dracut-memstack" package. Is this what you
wanted? If you want just "dracut-memstack", you should use "%package
-n".
It should be a memstrack-dracut sub package, so I'll change it to "%package
dracut"
>%build
>make
You should use %set_build_flags before the make invocation in order to use
Fedora's CFLAGS.
>%files
>%{_bindir}/memstrack
>%files dracut-memstrack
>%{dracutmoduledir}/module-setup.sh
>%{dracutmoduledir}/start-tracing.sh
>%{dracutmoduledir}/stop-tracing.sh
>%doc
1. Please put an empty line between the main package's %files and the
subpackages' list.
2. You must include the licence text.
https://docs.fedoraproject.org/en-US/packaging-guidelines/
LicensingGuidelines/#_license_text
3. The list does not include the module directory itself - RPM will complain
that the directory is unowned.
4. If %doc is going to be empty, you can just remove it.
Good suggestions, will fix it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component