Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xtide - Calculate tide all over the world
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-10-26 10:09 EST
-------
(In reply to comment #53)
Indeed this is rawhide breakage. Either the guidelines or
desktop-file-utils should be updated.
Jesse Keating commented on fedora-extras-list.
https://www.redhat.com/archives/fedora-extras-list/2006-October/msg00722....
It works better now, but I am not convinced that it is
the proper fix. I don't see why you need to send the
echo output on STDERR?
Simply because I wanted to send to stderr because it is a
error.
Removing.
And also it seems that failure should be used instead of
echo_failure
since it does something when with rhgb (show details).
Okay.
Moreover I think the [ FAILED ] should appear before the
explanation.
It leads to the following code:
if test -z "$PORT" ; then
failure
echo
echo $"PORT environment is not set."
RETVAL=1
return $RETVAL
My recognition is that usually OK of FAILED appears at the last
and the location of "failure" should be under the explanation.
Another remark is that I think having HOME defaulting to /root is
wrong,
it should be set to a directory below sysconfig, for example
%{_sysconfig}/xtide.
Okay.
And I am not completly convinced that using
nobody as a user is the right thing to do, maybe a specific user
would be better.
Well, for this I will reply later.
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.