https://bugzilla.redhat.com/show_bug.cgi?id=1877006
--- Comment #42 from Jordi Sanfeliu <jordi(a)fibranet.cat> ---
(In reply to Petr Pisar from comment #37)
FIX: Missing an Url tag in the spec file pointing to an upstream. Did
you
mean <
https://github.com/jcbf/smf-spf>?
Yes, done.
FIX: Source0 looks like a VCS snapshot. Put a URL you cloned it from
into a
comment above Source0 tag
<
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
#_using_revision_control>. Or use a URL of the snapshot if the upstream VCS
hosting system supports it.
OK, done.
FIX: Version does not follow a schema for snapshots
<
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
#_snapshots>. Consider what would happen if you need to upgrade to a
"051e937" snapshot of a 2.5.1-post release. In your current schema the new
version would sort lower than the old version.
OK, done.
TODO: It looks like the tests come from The Trusted Domain Project
which
uses <
https://github.com/trusteddomainproject/OpenDKIM/blob/master/LICENSE>.
That license requires carrying the license text. However, I cannot see the
license text anywhere in the source archive. You should clarify with the
upstream an origin of the tests. If upstream confirms it, the upstream and
you need to supply the missing license text.
I'll talk with upstream author to clarify this license mess.
FIX: Remove "rm -rf spf2" command from %prep. There is no
such directory in
the archive.
OK, done.
TODO: Use "install -m0644" instead of "cp -a" for
copying the additional
sources. A mode of the files is undefined. It depends on umask of the host
which builds the package.
OK, done
FIX: Remove a duplicate "BuildRequires:
systemd-rpm-macros".
FIX: Remove "Requires(pre): shadow-utils". A correct dependency is handled
with "%{?sysusers_requires_compat}" macro.
FIX: Build-requires "coreutils" (smf-spf.spec:52).
FIX: Build-require "make" (smf-spf.spec:49).
OK, done.
FIX: The README.rpm is out-dated. "service",
"chkconfig" commands are now
replaced with systemctl. Recommendation to install dependencies like libspf2
and sendmail is pointless. These are handled with RPM run-time dependencies
of this package. If sendmail-cf is required, then smf-spf or sendmail should
run-require it.
OK, done.
FIX: The lua script still fails:
error: lua script failed: [string "add_sysuser"]:16: invalid sysuser type:
#Type
3< (%lua)
2< (%add_sysuser)
Have you tried removing a first line with the comment from the file? At this
step the file is interpreted by Lua script of rpmbuild to generated RPM
Provides and it's possible that the script does not support comments.
OK, done.
FIX: smf-spf.sysusers declares /var/lib/smfs as a home directory, but
that
directory is not packaged. I think you should use "-" or "/run/smfs"
instead. See sysusers.d(5) manual page.
OK, done.
FIX: /run/smfs directory disappears on reboot because /run is tmpfs.
Use
<
https://docs.fedoraproject.org/en-US/packaging-guidelines/Tmpfiles.d/> for
creating one with correct ownership and mode.
OK, done.
TODO: Does this mail filter work only with sendmail? If it also works
with
postfix, the package should depend on "(sendmail or postfix)".
OK, done.
- Please, find the latest .spec and SRPM versions here
Spec URL:
https://ftp.fibranet.cat/smf-spf/smf-spf.spec
SRPM URL:
https://ftp.fibranet.cat/smf-spf/smf-spf-2.5.1^20220423g061e937-1.fc38.sr...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1877006
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...