https://bugzilla.redhat.com/show_bug.cgi?id=2056369
--- Comment #2 from Scott K Logan <logans(a)cottsay.net> ---
Thank you very much for the detailed review, Jakub.
I don't know if it is required yet but we are moving towards SPDX
license names...
A blog post[1] by Matthew Miller in July indicates that the new identifiers
should be used "going forward", however I can't find a documented consensus
for
dealing with older branches like EPEL 7, or even what qualifies as an "old
branch". Given that we haven't switched existing packages to the new
identifiers yet, I'm inclined to move forward with the old identifier here to
maintain a uniform spec. Another note, it doesn't look like rpmlint fully
supports the new identifiers yet either. I am excited for this change, though!
I am thinking about whether we should rather use
https://github.com/colcon/colcon-alias
My instinct is typically to follow the maintainer's lead and take the URL
directly from the setup.cfg[2]. In this case, I'm the upstream maintainer!
Using colcon.readthedocs.io made sense for many of the more "core" extensions
that are documented there, but as the ecosystem grows, we will continue to
encounter extensions which aren't documented there. I think this request makes
sense - and I'll update the setup.cfg as well.
Can you please write 2-3 sentences about the package here?
This is another reasonable request that I should implement upstream in the
setup.cfg or README.md and then pull that change in here.
I wanted to point out a couple of non-standard things in the spec but
adhering to the boilerplate of other colcon packages makes a lot of sense and it is IMHO a
better idea than nitpicking, so otherwise LGTM.
I appreciate this. There are a lot of colcon packages. I intend to update all
of the packages to use more modern spec files at some point, but much of that
is complicated by maintaining EPEL 7 branches of nearly all of the colcon
packages.
Thanks again - I'll implement the URL and description changes and report back
when that's been released and updated in this spec.
[1]
https://communityblog.fedoraproject.org/important-changes-to-software-lic...
[2]
https://github.com/colcon/colcon-alias/blob/main/setup.cfg#L4
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2056369