https://bugzilla.redhat.com/show_bug.cgi?id=1722843
Gordon Messmer gordon.messmer@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gordon.messmer@gmail.com
--- Comment #3 from Gordon Messmer gordon.messmer@gmail.com --- Hello, Shraddha. I am also not yet sponsored, but I would like to offer some feedback which might help you get this package through the review process more quickly when a sponsored packager looks at it. These are merely suggestions, but I believe that a reviewer will flag each of these issues:
* Please provide a link to the raw text file for the spec, and not to an HTML wrapper.
* Include changelog entries for each revision of your spec.
* Consider using this: %{python3_sitelib}/%{pypi_name}-*.egg-info/ instead of this: %{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info The latter may break if Python 3.10 is the version after 3.9. The former is similar to the example here: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_p...
* You may be able to simplify the spec by removing "Requires: python3dist(fedora-messaging) Requires: python3dist(setuptools)" and allowing the dependency generator to handle those automatically, as long as you're not building for Fedora < 30.
* You might choose to simplify the spec by replacing "BuildRequires: python3dist(fedora-messaging)" with "BuildRequires: %{py3_dist fedora-messaging}"
* It may not be necessary to "rm -rf %{pypi_name}.egg-info" (https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...)
(I think that covers everything in https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/)