https://bugzilla.redhat.com/show_bug.cgi?id=1939875
--- Comment #6 from Otto Urpelainen <oturpe(a)iki.fi> ---
Good progress!
After the latest updates, fedora-review ran to completion, so review can
progress.
7. The source tree comes bundled with tools/xxd.exe. This Windows binary is of
course useless, and brings more licensing issues, since the Vim license [1]
also requires including a copy. Could also that be removed from in %prep?
I have to admit being a little lost regarding the license violations: Bad items
can be removed in %prep, but they still end up in the srpm. Is that a problem?
I sent a question to the packaging mailing list about this [2])
8. Changelog formatting is slightly off: Character '-' should be used between
version and release parts. Reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs (also, I
do not think it is necessary to keep a changelog for changes made during review
— but not wrong either, if you prefer to have those)
9. fedora-review spotted discrepancy between given spec and srpm:
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
See: (this test has no URL)
Diff spec file in url and in SRPM
---------------------------------
---
/home/otto/src/Jakelut/Fedora/Katselmointi/litehtml/1939875-litehtml/srpm/litehtml.spec
2021-03-21 08:58:47.234730891 +0200
+++
/home/otto/src/Jakelut/Fedora/Katselmointi/litehtml/1939875-litehtml/srpm-unpacked/litehtml.spec
2021-03-19 12:43:35.000000000 +0200
@@ -76,5 +76,5 @@
%changelog
-* Fri Mar 19 2021 Sandro Mani <manisandro(a)gmail.com> -
0.5.1.20210317gitb6442d9
+* Fri Mar 19 2021 Sandro Mani <manisandro(a)gmail.com> - 0.5.1.gitb6442d9
- Update to git b6442d9
- Drop upstreamed patches
[1]:
https://github.com/vim/vim/blob/master/LICENSE
[2]:
https://lists.fedoraproject.org/archives/list/packaging@lists.fedoraproje...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component