https://bugzilla.redhat.com/show_bug.cgi?id=1737063
Richard W.M. Jones <rjones(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rjones(a)redhat.com
--- Comment #1 from Richard W.M. Jones <rjones(a)redhat.com> ---
Some thoughts before the formal review:
- Usually best to use --profile release with dune, to disable warnings.
- There seems to be a LICENSE file upstream. Is it missing from the tarball?
It should be added to the %license section if possible.
- Lines like %{_libdir}/ocaml/*/... are a bit strange (and unsafe). Probably
best to use %{_libdir}/ocaml/%{libname}/... instead
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component