Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pmtools - power management debugging tools
https://bugzilla.redhat.com/show_bug.cgi?id=437397
------- Additional Comments From lkundrak(a)redhat.com 2008-03-14 23:18 EST -------
(In reply to comment #1)
5.) %setup -q
..
%build
cd %{name}-%{version}
...
%install
...
cd %{name}-%{version}
Those cds are not nice. Take a look at %setup -n
http://www.rpm.org/max-rpm/s1-rpm-inside-macros.html
Actually this is completely not needed. RPM cds there without explicit =n and
your cds break it.
8.) Either use $RPM_BUILD_ROOT or %{buildroot}, but do not mix those
9.) You don't pass %{mflags} to make; if parallel make breaks the build at least
add a comment about that
Review will continue once the package is buildable.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.