Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517743
--- Comment #15 from Sandro Mathys <sm(a)sandro-mathys.ch> 2009-12-27 09:33:56 EDT
---
Spec URL:
http://red.fedorapeople.org/SRPMS/PyPE.spec
SRPM URL:
http://red.fedorapeople.org/SRPMS/PyPE-2.9-1.fc12.src.rpm
(In reply to comment #13)
This is a MUST. ;)
If you have multiple licenses, you have to e.g. refer to in this case
readme.txt or say in a comment, which files have which license.
Oh, I thought that only applies for the old version where licensing was not
clear. But now that I actually read the link it's clear :) Wonder why I never
saw this before, I pretty sure have other multi-license packages :/
FIXED (comment above License)
anything under wxWidgets can be relicensed under GPL. BUT in fact,
Josiah has
already done that
But the whole file itself is GPL -> no wxWidgets everywhere.
Right, after reading through the license comments again, seems to be sane.
What is copyrighted under LGPL?
There is a lgpl.txt, but that's it. Or am I wrong?
Josiah already answered that :) And so did you in comment #5 btw :)
So, it stays for me: GPLv2.
So it's GPLv2 and LGPLv2. FIXED
########################################
Some other issues:
- $RPM_BUILD_ROOT%{_datadir}/%{name} is created, but empty (rest of old icon
path) -> not needed anymore.
Hm...right. FIXED
- sed -i -e "s;PYTHONPATH;%{python_sitelib};g" %{SOURCE1}
has no effect. There is no pythonpath in the .desktop ( yet? ;) )
Uh, good catch! Grabbed the wrong desktop file in the end :/ FIXED
- Don't copy *.pyc and *pyw.
They are created later in the /usr/lib/rpm/brp-python-bytecompile part
anyway.
See
https://fedoraproject.org/wiki/Packaging/Guidelines#No_inclusion_of_pre-b...
MUST: don't install them, and Josiah please don't include them (same for
*.dll);)
FIXED. Not upstream tho.
- changelog format:
There is '* new version' -> '- new version'
Awww, right. FIXED
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.