https://bugzilla.redhat.com/show_bug.cgi?id=1876108
--- Comment #33 from Lyes Saadi fedora@lyes.eu ---
- The License field is still not quite right. The license that licensecheck
calls "NTP License (legal disclaimer)" is called "HPND" in SPDX parlance. That is the license for these files:
Indeed! I missed that, thanks!
- I don't think that removing the shebangs from pyfiglet/__init__.py and
pyfiglet/test.py is the right thing to do. Both are made to be executable. Instead, the shebangs should be fixed in %prep; e.g., like this:
%py3_shebang_fix pyfiglet/{__init__,test}.py
Then, because the installer strips the executable bits off, add them back in %install instead of removing the shebangs:
chmod 0755 %{buildroot}%{python3_sitelib}/%{pypi_name}/{__init__,test}.py
Indeed! I should've never removed the shebang.
- Please consider not building for i686, by adding this to the spec file:
ExcludeArch: %{ix86}
See https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
Will add!
- Note the file-not-utf8 warning from rpmlint below. The file doc/figfont.txt
is encoded with ISO8859-1 instead of UTF-8.
Whoops, missed the error, will PR a UTF-8 file.
The LICENSE file in the dist-info is marked as a license already, so there is no need to include it a second time with %license:
$ rpm -qLp python3-pyfiglet-1.0.2-1.fc40.noarch.rpm /usr/lib/python3.12/site-packages/pyfiglet-1.0.2.dist-info/LICENSE /usr/share/licenses/python3-pyfiglet/LICENSE
Oh, neat ! Didn't know pyproject did that !
- The comment in %check is misleading. The pytest tests fail, not because of a missing subprocess module (which is builtin to python), but rather because they try to use the doh font from fonts-contrib. We have removed fonts-contrib for license reasons. I wonder if upstream could be prevailed upon to use a font in fonts-standard for the tests.
Oh, I didn't recheck why I disabled tests, I also thought that my explanation was weird when I got back to the package. I'll submit a merge request changing the font used for tests.