https://bugzilla.redhat.com/show_bug.cgi?id=1086664
Vít Ondruch <vondruch(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #5 from Vít Ondruch <vondruch(a)redhat.com> ---
* Test suite
- You should run the test suite from "pushd .%{gem_instdir}". That way you
don't need to delete the test suite, i.e. you can remove the 'rm -rf
test/'.
- Please remove the '&&' at the end of the first batch of tests. It
makes the
testsuite to pass even if it fails.
* Useless provide
- You package has "Provides: rubygem(%{gem_name})" but it is now
autogenerated. Please remove the provide (it will avoid also one rpmlint
complaint).
* rpmlint
- rubygem-actionview-doc.noarch: W: summary-ended-with-dot C Documentation
for
rubygem-actionview.
Otherwise the package looks good => APPROVED. Please fix the above mentioned
minor nits prior importing and don't forget to disable bootstrap after first
successful build.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component