Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698067
Volker Fröhlich <volker27(a)gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |volker27(a)gmx.at
--- Comment #2 from Volker Fröhlich <volker27(a)gmx.at> 2011-05-07 10:08:31 EDT ---
Some comments:
There is a version 0.10.0 release upstream. Please update!
You can drop your second patch and instead write:
make install PREFIX=%{buildroot}/%{_prefix} INSTALL_LIB=%{buildroot}/%{_libdir}
That's also replacing /usr with %{_prefix}. Please also place comments on your
patches do in the spec file. You can use the name macro on some occasions, e.
g. when installing.
I think you can make up a better description, given the description on the
homepage. The description of the devel package even seems wrong to me, because
the devel package certainly does not contain libraries to use a database.
redis should be a BuildRequires -- not a Requires.
I don't know how you managed the EPEL 6 build. Currently there is only a redis
in testing, as far as I can see.
The compiler flags are not as requires by Fedora. See
http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
Please install the TODO file as documentation.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.