https://bugzilla.redhat.com/show_bug.cgi?id=1670656
Elliott Sales de Andrade <quantum.analyst(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(quantum.analyst@g |
|mail.com) |
--- Comment #25 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com> ---
(In reply to Mark Goodwin from comment #24)
In addition to Xavier's notes and questions in Comment #23,
rpmlint issues
warnings that Provides: bundled(foo) should be versioned.
# rpmlint RPMS/x86_64/grafana-5.4.3-10.fc28.x86_64.rpm
grafana.x86_64: W: unstripped-binary-or-object /usr/sbin/grafana-cli
grafana.x86_64: W: unstripped-binary-or-object /usr/sbin/grafana-server
This should be done somehow (automatically, I'd have thought), since debug
information is in the -debuginfo subpackage. It seems like it might be because
you've disabled debug packages; why is that?
grafana.x86_64: W: non-standard-gid /etc/grafana/grafana.ini grafana
grafana.x86_64: E: non-readable /etc/grafana/grafana.ini 640
grafana.x86_64: W: non-standard-gid /etc/grafana/ldap.toml grafana
grafana.x86_64: E: non-readable /etc/grafana/ldap.toml 640
grafana.x86_64: E: non-readable /etc/sysconfig/grafana-server 640
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/defaults.ini grafana
grafana.x86_64: E: non-readable /usr/share/grafana/conf/defaults.ini 640
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/distro-defaults.ini grafana
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/ldap.toml grafana
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/provisioning grafana
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/provisioning/dashboards
grafana
grafana.x86_64: W: non-standard-gid
/usr/share/grafana/conf/provisioning/dashboards/sample.yaml grafana
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/provisioning/datasources
grafana
grafana.x86_64: W: non-standard-gid
/usr/share/grafana/conf/provisioning/datasources/sample.yaml grafana
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/sample.ini grafana
grafana.x86_64: W: non-standard-uid /var/lib/grafana/data grafana
grafana.x86_64: W: non-standard-gid /var/lib/grafana/data grafana
grafana.x86_64: E: non-standard-dir-perm /var/lib/grafana/data 750
grafana.x86_64: W: non-standard-uid /var/lib/grafana/data/plugins grafana
grafana.x86_64: W: non-standard-gid /var/lib/grafana/data/plugins grafana
grafana.x86_64: E: non-standard-dir-perm /var/lib/grafana/data/plugins 750
grafana.x86_64: W: non-standard-uid /var/log/grafana grafana
grafana.x86_64: W: non-standard-gid /var/log/grafana grafana
I assume you've followed the instructions on
https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/ ?
grafana.x86_64: E: script-without-shebang
/usr/share/grafana/public/app/plugins/datasource/elasticsearch/img/elasticsearch.svg
grafana.x86_64: E: script-without-shebang
/usr/share/grafana/public/fonts/grafana-icons.svg
These should not be executable.
grafana.x86_64: W: hidden-file-or-dir
/usr/share/grafana/public/sass/.sass-lint.yml
grafana.x86_64: W: hidden-file-or-dir /usr/share/grafana/public/test/.jshintrc
Delete these development files.
grafana.x86_64: W: log-files-without-logrotate
['/var/log/grafana']
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_log_files
# rpmlint SRPMS/grafana-5.4.3-10.fc28.src.rpm
grafana.src:98: W: unversioned-explicit-provides ...
It seems like you have bundled provides for things you've removed from the
source. You don't need to add those (though yes, technically, it's statically
bundled, the macros should do that sort of thing for you.)
grafana.src:503: W: macro-in-%changelog %doc
Remove macro from changelog.
Some other things:
* No, I don't think you need to do `Provides:
bundled(golang(github.com/repo/package))` instead of `Provides:
bundled(golang-github-repo-package-devel)`.
* From what I've read, nodejs macros will automatically add bundled provides
for you; we should do this in the Go macros.
* Fedora 27 is EOL; there's no need to support it.
*
golang(github.com/hashicorp/go-version) is available; you can unbundle it.
* The %if 0%{?fedora} || 0%{?rhel} check seems redundant.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component