https://bugzilla.redhat.com/show_bug.cgi?id=1732894
--- Comment #16 from Mat Booth <mat.booth(a)redhat.com> ---
(In reply to Fabio Valentini from comment #14)
A few comments outside the review template:
0. It looks like at least some of the included files are indeed licensed EPL
(1.0 / 2.0), not BSD. Please make sure they're not shipped as part of the
binary RPM, or adapt License tag accordingly and add a license file to the
package with %license.
I will a comment to the spec file explaining it too :-)
1. If git is a BR for tests, you could move it under %{with tests} as well.
Yes, good point
2. "%package -n jgit-javadoc" -> "%package javadoc" (same for
description),
I guess this is a leftover from the eclipse-jgit packaging.
Yes, good guess :-)
3. Do we need to build the source jar? otherwise, we can remove
maven-source-plugin from the pom and BRs.
True -- I'm pretty sure the existing eclipse-jgit package does not ship the
source for the eclipse plugin part, so it should be okay to do this.
4. Why are failing tests ignored even when the build is run
"--with tests"?
Good question! There used to be an intermittant failure, but I don't recall the
details and it may be fixed in recent versions. Let's try not ignoring it :-)
5. I think you could truncate the %changelog as well, since this is a
new
package.
Sure, happy to do that.
6. Will eclipse-jgit have a versioned dependency on this package, to
make
sure they're updated at the same time?
Yes. FWIW the eclipse-egit package also has a versioned dependency on
eclipse-jgit since this is all very tightly coupled.
PS: Will splitting eclipse-jgit into two packages also solve the bootstrap
issue in eclipse-jgit?
Yes, this is bonus benefit for me since I will no longer have to deal with the
split-phase build process :-) The maven pom-centric parts are moved to this
package and the OSGi manifest-centric parts remain in eclipse-jgit
Full review below.
Thanks for the review, I will upload a revised spec shortly!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component