https://bugzilla.redhat.com/show_bug.cgi?id=1503915
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |mhroncok(a)redhat.com
Assignee|nobody(a)fedoraproject.org |mhroncok(a)redhat.com
--- Comment #8 from Miro Hrončok <mhroncok(a)redhat.com> ---
OK. Let me take this. Here are my suggestions:
1. I find the spec file very hard to read. I suggest you give it some air with
empty lines on appropriate places and reorder some lines to more common order.
See for example
https://src.fedoraproject.org/rpms/uflash/blob/master/f/uflash.spec
2. The spec file references Fedora 26 several times, but that is EOL.
3. If you really need to have if RHEL conditionals for python2 / python3,
follow what Neal says above.
4. Use the %py3_build and %py3_install (or %py_build and %py_install) macros.
5. Use a publicly accessible website for URL.
6. Don't put # in description.
7. Please no INSTALLED_FILES.
8. Use %{buildroot} instead of $RPM_BUILD_ROOT
9. Is there no /usr/bin/roca-detect created by upstream's setup.py? Why the
cat?
10. As %check gets executed after %install I suggest you move it bellow.
11. Give the patch a number, use %autosetup if possible.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component