Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459800
Toshio Ernie Kuratomi <a.badger(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |a.badger(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |a.badger(a)gmail.com
Flag| |fedora-review?
--- Comment #3 from Toshio Ernie Kuratomi <a.badger(a)gmail.com> 2008-09-29 20:18:29
EDT ---
NEEDSWORK
Good:
* Named according to the package naming guidelines and spec matches
* Licensed appropriately:
Regarding your note about test/web/post_multipart.py, you probably want to
add a link to this:
http://code.activestate.com/help/terms/. (That would be
Python for this code snippet)
* Spec file is legible.
* Tarball matches upstream.
* Not a shared library package
* Builds in mock on i386
* package owns all directories it creates and no others
* all filenames are utf-8
* proper %clean
* macros used consistently
* No duplicate files
* package contains code not content
To be fixed:
* rpmlint:
python-py.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/py/c-extension/greenlet/greenlet.so 0775
3 packages and 0 specfiles checked; 1 errors, 0 warnings.
Not sure why setuptools is making this 0755 instead of 0755 but you can correct
it in your spec file:
%install
[...]
chmod 0755 %{buildroot}%{python_sitearch}/py/c-extension/greenlet/greenlet.so
* The package has a compat directory with modules that are also in the
stdlibrary. It looks like they're just copies svn around the 2.4.4 release.
These have to go.
I'd suggest the following:
- For the Fedora package, our goal is to be able to rm -rf py/compat. We
should do this in the spec file.
- For upstream we need a patch that first tries system libraries and then
fallsback to the py/compat modules if necessary.
When patching the source we probably need to grep for occurrences of "compat"
in the source. Then change things like this::
import py
usage = "usage: %prog [-s [filename ...] | [-i | -c filename ...]]"
optparser = py.compat.optparse.OptionParser(usage)
to::
import py
try:
import optparse
except ImportError:
from py.compat import optparse
usage = "usage: %prog [-s [filename ...] | [-i | -c filename ...]]"
optparser = py.compat.optparse.OptionParser(usage)
This second problem is important enough to require fixing before approval.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.