Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507157
--- Comment #4 from Jussi Lehtola <jussi.lehtola(a)iki.fi> 2009-06-23 02:21:40 EDT
---
(In reply to comment #3)
Issues:
- mockbuild fails with:
rm: cannot remove `/usr/bin/vefte': No such file or directory
see
http://koji.fedoraproject.org/koji/taskinfo?taskID=1431125
This is weird, because when I comment out the line it fails due to unpackaged
files:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1431152
You should test if the file is really there before removing it.
Ugh, missing %{buildroot} before %{_bindir}. Fixed.
- better use pushd/popd instead of cd src/cd ..
Maybe, if the directory structure was more complicated. The stack operations
pushd/popd seem a like an overkill :)
- Omit INSTALL from %doc, it's useless
Whoops, shouldn't have been there.
- "Categories=Development;TextEditor;" in the desktop file
looks a little
unconventional, but I guess in this case it is correct.
Yes, since this is an editor for programmers.
http://theory.physics.helsinki.fi/~jzlehtol/rpms/efte.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/efte-1.0-4.fc11.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.