https://bugzilla.redhat.com/show_bug.cgi?id=2178190
Sandro <gui1ty(a)penguinpee.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #7 from Sandro <gui1ty(a)penguinpee.nl> ---
(In reply to Ben Beasley from comment #3)
Thank you for the review!
(In reply to Sandro from comment #2)
> ===== Issues =====
>
> [!]: License field in the package spec file matches the actual license.
> => License string appears to be incomplete. See:
>
https://download.copr.fedorainfracloud.org/results/%40fedora-review/fedora-
> review-2178190-mmlib/fedora-rawhide-x86_64/05640709-mmlib/fedora-review/
> licensecheck.txt
I think it’s complete. The following are the files for which licensecheck
detects something other than Apache-2.0:
*No copyright* NTP License
--------------------------
mmlib-1.4.2/src/mmtime.h
FSF All Permissive License
--------------------------
mmlib-1.4.2/m4/mm_python_module.m4
Your explanation makes sense. No action required. I should have looked into the
files myself. Thanks for the extended feedback.
(In reply to Ben Beasley from comment #4)
In the following, README.md and TODO.md have been moved from
mmlib-devel to
mmlib.
I think it makes sense to have these in the main package (and it means one less
warning from rpmlint). Keeping examples/ in the devel package is also okay.
All in all ==> APPROVED!
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2178190