[Bug 1517451] Review Request: gtk-radio 246.1
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
| |needinfo?(oka(a)oka.no)
| |needinfo?(oka(a)oka.no)
Assignee|nobody(a)fedoraproject.org |dominik(a)greysector.net
--- Comment #41 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net> ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #40)
[...]
> To elaborate, girl appears to be maintained upstream:
> https://gitlab.gnome.org/GNOME/gnome-internet-radio-locator
>
> Last commit was 4 months ago.
Ok, upon further reading it does seem like upstream intends to replace it
with gtk-radio. I guess we should proceed here, then.
Some review comments below:
Provides: gtk-internet-radio-locator >= 128.0
Drop the greater-than, this should be equal only.
You are also mixing tabs and spaces, please replace tabs with spaces in:
Obsoletes:<TAB>gtk-internet-radio-locator <= 128.0
Provides:<TAB>gtk-internet-radio-locator = 128.0
%post section is empty, drop it.
License: tag is not SPDX-compliant, please fix.
%{_mandir}/man1/gnome-radio.1.gz
%{_mandir}/man1/gtk-internet-radio-locator.1.gz
These should be:
%{_mandir}/man1/gnome-radio.1.*
%{_mandir}/man1/gtk-internet-radio-locator.1.*
and moved next to:
%{_mandir}/man1/%{name}.1*
building on rawhide-x86_64 fails with:
...
configure: error: in `/builddir/build/BUILD/gtk-radio-264.1':
configure: error: C compiler cannot create executables
See `config.log' for more details
config.log duly informs that you forgot to add explicit BuildRequires: gcc:
...
configure:4251: gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g
-grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTI>
./configure: line 4253: gcc: command not found
After fixing that, I get:
Package 'geoclue-2.0', required by 'virtual:world', not found
Package 'libgeoclue-2.0', required by 'virtual:world', not found
After fixing that (BuildRequires: pkgconfig(geoclue-2.0)), I get a warning:
configure: WARNING:
You will not be able to create source packages with 'make dist'
because gtk-doc >= 1.16 is not found.
and then a compilation error:
gnome-radio-location.c: In function ‘location_main’:
gnome-radio-location.c:193:27: error: passing argument 3 of ‘gclue_simple_new’
makes pointer from integer without a cast [-Wint-conversion]
193 | time_threshold,
| ^~~~~~~~~~~~~~
| |
| gint {aka int}
and tons of warnings about deprecated GTimeVal usage, e.g.:
gnome-radio-location.c:89:9: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime'
instead [-Wdeprecated-declarations]
This looks suspicious as well:
In file included from /usr/include/libgeoclue-2.0/geoclue.h:35,
from gnome-radio-location.c:33:
/usr/include/libgeoclue-2.0/gclue-simple.h:65:64: note: expected ‘GCancellable
*’ {aka ‘struct _GCancellable *’} but argument is of type ‘gint’ {aka ‘int’}
65 | GCancellable
*cancellable,
|
~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
I'd be happy to sponsor you once this package is ready for Fedora Rawhide.
Since Robert-André is no longer assigned here, I'll pick up the review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-...
1 month, 1 week
[Bug 2274206] New: Review Request: valkey - A persistent key-value
database
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2274206
Bug ID: 2274206
Summary: Review Request: valkey - A persistent key-value
database
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: jonathan(a)almalinux.org
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://download.copr.fedorainfracloud.org/results/jonathanspw/valkey/fed...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jonathanspw/valkey/fed...
Description:
Valkey is an advanced key-value store. It is often referred to as a data
structure server since keys can contain strings, hashes, lists, sets and
sorted sets.
You can run atomic operations on these types, like appending to a string;
incrementing the value in a hash; pushing to a list; computing set
intersection, union and difference; or getting the member with highest
ranking in a sorted set.
In order to achieve its outstanding performance, Valkey works with an
in-memory dataset. Depending on your use case, you can persist it either
by dumping the dataset to disk every once in a while, or by appending
each command to a log.
Valkey also supports trivial-to-setup master-slave replication, with very
fast non-blocking first synchronization, auto-reconnection on net split
and so forth.
Other features include Transactions, Pub/Sub, Lua scripting, Keys with a
limited time-to-live, and configuration settings to make Valkey behave like
a cache.
You can use Valkey from most programming languages also.
Fedora Account jonathanspw
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2274206
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-...
1 month, 1 week