https://bugzilla.redhat.com/show_bug.cgi?id=2119552
Bug ID: 2119552 Summary: Review Request: google-disk-expand - Expands root partition in Google Cloud instances Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mhayden@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/pkgreview/fedora-... SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/pkgreview/fedora-... Description: Expands root partition in Google Cloud instances Fedora Account System Username: mhayden
COPR fedora-review: https://download.copr.fedorainfracloud.org/results/mhayden/pkgreview/fedora-...
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
Ryan Phillips rphillips@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rphillips@redhat.com
--- Comment #1 from Ryan Phillips rphillips@redhat.com --- Node Team on OpenShift is expanding out cri-o's CI infrastructure. This fix will be needed for our CI testing on Fedora 36.
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
--- Comment #2 from Major Hayden 🤠 mhayden@redhat.com --- Ryan: Was there a particular fix you were looking for? Or, do you just need this packaged in Fedora?
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
--- Comment #3 from Ryan Phillips rphillips@redhat.com --- It would be great if this were packaged by default within Fedora so we can use the released cloud image in GCP.
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
--- Comment #4 from Major Hayden 🤠 mhayden@redhat.com --- Awesome. That's my goal. I'm working on google-osconfig-agent as well.
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
--- Comment #5 from Ryan Phillips rphillips@redhat.com --- Thank you!
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? | |needinfo?(mhayden@redhat.co | |m) Assignee|nobody@fedoraproject.org |jonathan@almalinux.org CC| |jonathan@almalinux.org
--- Comment #6 from Jonathan Wright jonathan@almalinux.org --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "Apache License 2.0". 9 files have unknown license. Detailed output of licensecheck in /home/jonathan/fedora-review/2119552-google-disk- expand/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/dracut/modules.d/50google-disk-expand [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/dracut/modules.d/50google-disk-expand [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in google-disk-expand [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/GoogleCloudPlatform/guest-diskexpand/archive/20220712.00/... : CHECKSUM(SHA256) this package : db3c1c49d659ce582c42260e14273d99bbd0ec363528f083c56a2727d4d15608 CHECKSUM(SHA256) upstream package : db3c1c49d659ce582c42260e14273d99bbd0ec363528f083c56a2727d4d15608
Requires -------- google-disk-expand (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash /usr/bin/sh dracut e2fsprogs gdisk grep parted systemd util-linux
Provides -------- google-disk-expand: google-disk-expand
Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2119552 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Ocaml, PHP, Haskell, R, Python, fonts, SugarActivity, Perl, C/C++, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comments:
License: ASL 2.0
Needs to be SPDX. [1]
1. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
Confirm you'll fix it in the package and I'll go ahead and approve this.
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
Major Hayden 🤠 mhayden@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mhayden@redhat.co |needinfo?(jonathan@almalinu |m) |x.org)
--- Comment #7 from Major Hayden 🤠 mhayden@redhat.com --- Thank you, Jonathan! I'll adjust that to 'Apache-2.0'. Should I build another SRPM for you?
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(jonathan@almalinu | |x.org) |
--- Comment #8 from Jonathan Wright jonathan@almalinux.org --- Nope I trust ya to fix it! Approved!
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
--- Comment #10 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/google-disk-expand
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-7837378e7e has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7837378e7e
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2022-08-22 14:37:00
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-7837378e7e has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-8e8f0e5534 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8e8f0e5534
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-8e8f0e5534 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
Sohan Kunkerkar skunkerk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |skunkerk@redhat.com
--- Comment #15 from Sohan Kunkerkar skunkerk@redhat.com --- (In reply to Major Hayden 🤠 from comment #2)
Ryan: Was there a particular fix you were looking for? Or, do you just need this packaged in Fedora?
Is it possible to backport this fix to Fedora 36 as well?
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
--- Comment #16 from Major Hayden 🤠 mhayden@redhat.com --- Sohan -- will do that this morning.
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-64ff06a92f (google-disk-expand-20240228.00-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-64ff06a92f
https://bugzilla.redhat.com/show_bug.cgi?id=2119552
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-64ff06a92f (google-disk-expand-20240228.00-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org