[Bug 187317] Review Request: mindi - Creation of emergency boot
disks/CDs using your kernel, tools and modules
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=187317
Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
--- Comment #49 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> ---
- This need to be justified or fixed:
# Avoids to generate debug packages
%global debug_package %{nil}
- Again why the non standard release info:
Release: 0.20201118013837.s3776M%{dist}
It should be 1.
- Not used in Fedora
Group:
- Not needed
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -u -n)
- Not available for me:
Source:
ftp://ftp.mondorescue.org/test/src/%{srcname}-%{version}.0.20201118013837...
- I don't think we support ia64 anymore.
- Please justify this
ExclusiveArch: x86_64 i586 i386 i686 ia64
Why can't it be compiled on other arches?
- Not needed:
rm -rf $RPM_BUILD_ROOT
%clean
rm -rf $RPM_BUILD_ROOT
%defattr(-,root,root)
- The license file must be installed with %license in %files:
%license COPYING
- Is there a reason this is not noarchc it seems to be all perl and bash. You
should probably add:
BuildRequires: perl-generators
BuildRequires: perl-interpreter
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3 years, 4 months
[Bug 187318] Review Request: mondo - A program which a Linux user
can utilize to create a rescue/restore CD/tape
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=187318
Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
--- Comment #69 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> ---
- Use %global not %define
%global srcname mondo
- Group: is not used by Fedora
- Not needed:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -u -n)
- Please justify this, why wouldn't it be available on all Fedora supported
arches:
ExclusiveArch: x86_64 i586 i386 i686 ia64
(also use %{ix86} instead of i586 i386 i686
- make %{?_smp_mflags} → %make_build
- Not needed :
rm -rf $RPM_BUILD_ROOT
%clean
rm -rf $RPM_BUILD_ROOT
- make DESTDIR=$RPM_BUILD_ROOT install → %make_install
- Not needed it is the default:
%defattr(-,root,root)
- The license file COPYING must be installed with %license not %doc
%license COPYING
- I can't find:
ftp://ftp.mondorescue.org/test/src/mondo-3.3.0.0.20201118013837.tar.gz
I'd rather use http://www.mondorescue.org/ftp/src/
- The release is weird:
Release: 0.20201118013837.s3776M%{dist}
It should start at 1 for a release. Why are 20201118013837 and s3776M needed?
Is it extra versioning info?
--
You are receiving this mail because:
You are always notified about changes to this product and component
3 years, 4 months
[Bug 1619610] mozilla-filesystem to own
%_libdir/mozilla/native-messaging-hosts
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1619610
Jan Horak <jhorak(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Resolution|--- |NEXTRELEASE
Flags| |needinfo?(praiskup(a)redhat.c
| |om)
Last Closed|2020-11-24 19:34:48 |2021-01-20 15:58:13
--- Comment #12 from Jan Horak <jhorak(a)redhat.com> ---
Already merged by Martin. Do you need to release the update for the F32+ or is
the rawhide sufficient?
--
You are receiving this mail because:
You are on the CC list for the bug.
3 years, 4 months